Oh yeah I missed that, thanks
@bors r+ rollup

📌 Commit 0ab7842 has been approved by jieyouxu

It is now in the queue for this repository.

@bors r-

(Is there a reason this is draft?)

reason for draft is lack of an automated test, and i can't test manually right now due to the build system falling apart at the seams again.

if you wouldn't mind doing a quick local clone of this PR and making sure it works as intended (just build a rustdoc-js test at stage 0), that would be appricated.

otherwise i've gotta sort out this whole mess.

ok, did something serious regress?

i just deleted build, rebuilt everything, and i'm still getting this:

Error: Cannot find module '/home/binarycat/src/rs/rust/build/x86_64-unknown-linux-gnu/test/rustdoc-js/basic/search-index.js'
Require stack:
- /home/binarycat/src/rs/rust/src/tools/rustdoc-js/tester.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1225:15)
    at Module._load (node:internal/modules/cjs/loader:1051:27)
    at Module.require (node:internal/modules/cjs/loader:1311:19)
    at require (node:internal/modules/helpers:179:18)
    at loadSearchJS (/home/binarycat/src/rs/rust/src/tools/rustdoc-js/tester.js:403:25)
    at main (/home/binarycat/src/rs/rust/src/tools/rustdoc-js/tester.js:552:28)
    at Object.<anonymous> (/home/binarycat/src/rs/rust/src/tools/rustdoc-js/tester.js:583:1)
    at Module._compile (node:internal/modules/cjs/loader:1469:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
    at Module.load (node:internal/modules/cjs/loader:1288:32) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [ '/home/binarycat/src/rs/rust/src/tools/rustdoc-js/tester.js' ]
}

which suggests rustdoc is not even getting run.

if i run the test with --stage 1, then back with --stage 0, it works correctly.

looks like build artifacts are not being isolated enough or something??

anyways, i did get a stage0 rustdoc test to run successfully, so.. manual testing complete?

@rustbot review

anyways, i did get a stage0 rustdoc test to run successfully, so.. manual testing complete?

Opened #135603 for the stage 0 failure. I can reproduce the unexpected pass locally via --stage 1 -> --stage 0, but that's not really related to the changes in this PR. Thanks.

@bors r+ rollup

📌 Commit 0ab7842 has been approved by jieyouxu

It is now in the queue for this repository.

@bors r-

Actually, I did some investigation locally. I'm not convinced the current formulation of rustdoc-js was implemented with --stage 0 in mind. I would strongly prefer that we require COMPILETEST_FORCE_STAGE0 before we sort out this test suite to make less likely to be run accidentally at stage0.

./x test tests/rustdoc-js --stage 0 doesn't even build rustdoc, this can't be right.

I'm going to close in favor of #135605, that we keep requiring COMPILETEST_FORCE_STAGE0=0 to run rustdoc-js at --stage 0, which conflicts with this PR.